Wireshark-bugs: [Wireshark-bugs] [Bug 5466] Improve dissection of bit-oriented fields, text fiel
Date: Mon, 6 Dec 2010 11:18:23 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5466

--- Comment #7 from Richard Sharpe <[email protected]> 2010-12-06 11:18:22 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=5572)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5572) [details]
[details]
> > Final patch for the control field
> > 
> > This version fixes the control field in all of the packet-scsi*.c files.
> > 
> > I will likely look at more things over the next few days.
> 
> Is the offset wrong here?  Should it be:
>  +    proto_tree_add_bitmask(tree, tvb, offset+8, ... ?

Yes, that is one I missed. I tried to be careful there ... but missed that one.

> 
> Looks OK otherwise.  Passes tools/checkAPIs.pl.  tools/checkhf.pl does produce
> some "NO ARRAY" and "Unused entry" output, but I believe they're all false
> positivies.  Maybe you could just verify them all.

I will have to run tools/checkhf.pl across it :-)

> Do you have a(ny) capture file(s) you could post so the changes can be
> fuzz-tested?

I do have a capture of a bunch of iSCSI traffic ... (two actually and maybe
more at home).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.