https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5013
--- Comment #16 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-10-21 17:25:16 EDT ---
(In reply to comment #11)
>
> BTW, the checks like "if(fec_tree == NULL) return" could be simplified or
> mostly removed: the tree will either be NULL (at the beginning of the function)
> or not. If it's not NULL, proto_tree_add_subtree() won't generate a NULL tree
> either. Either way, checking for the tree being NULL is strictly optional at
> this point.
>
Done; Also many unneeded 'if(tree)' statements removed.
> ... remove checks like:
>
> + if ( (vc_len > 1) && ( rem > 1 ) ) { /* there is enough room
> for TAII */
> [...]
> + } else {
> + proto_tree_add_text(fec_tree,tvb,offset , 2 +vc_len,
> "Generalized FEC: TAII size format error");
> + return;
> + }
left for another time .... :)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
