Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 5286] Add support for well-known SIDs/RIDs and option to d

Date: Fri, 8 Oct 2010 11:51:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5286

--- Comment #3 from Guy Harris <guy@xxxxxxxxxxxx> 2010-10-08 11:51:54 PDT ---
(Just out of curiosity, why is DART showing SIDs differently from the way the
company that invented them does?  As I remember from my days at NetApp, Data
ONTAP shows 'em in decimal, Microsoft-style....)

It's "hexadecimal", not "hexidecimal".

Why does it need to include <epan/prefs-int.h>?  That's not intended for
dissectors to include, it's only for core modules that need to know some
internal details about how preferences are implemented.  If you're doing this
to allow multiple files to access the value of the "display in hex" preference,
I'd just make sid_display_hex global rather than static?

Some text disappeared from a comment:

-         * XXX should not be letohl but native byteorder according to
-         * Samba header files.

became

+        * XXt be letohl but native byteorder according to
+        * Samba header files.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.