Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 5248] New dissector for WAI authentication protocol

Date: Thu, 23 Sep 2010 02:25:45 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5248

--- Comment #12 from Lukasz Kotasa <lukasz.kotasa@xxxxxxxxx> 2010-09-23 02:25:43 PDT ---
(In reply to comment #9)
> Lukasz;
> 
> I've committed 2 changes  in SVN #30185:
> 
> 1. I've moved the reassembly code so that all of it is not under 'if (tree)';
> 2. I fixed the offset used for hf_wai_ecdh_content so that the correct bytes
> are highlighted in the "Packet Bytes" pane.
> 
> Please review my changes.

1. It's OK for me. I didn't know this can cause troubles. I trust you and Jeff
:)
2. You are correct, this was my error.

> Also:
> 
> Looking at some of the WAI frames in the capture I note other instances of
> apparently incorrect Packet Bytes highlighting when certain fields are selected
> in the Packet Details.
> 
> For example: 
> - the ASUE Signature field in frame #374;
> - the AE Signature field in frame #396

Fixed.

> Please review the offsets, etc used when displaying fields to make sure they
> are correct so that the right bytes are highlighted in the Packet Bytes pane
> for each field.
> 
> Thanks

I reviewed other fields and couldn't find more such errors. I fixed some typos 
in the newest patch.

Thanks for your review.
Lukasz

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.