https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3422
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
--- Comment #8 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-09-20 18:30:38 PDT ---
Yeah, those calls to tvb_get_ptr() gotta go. The loops could easily be
rewritten to use the standard accessor functions (tvb_get_*).
Other comments along the way:
- DISSECTOR_ASSERT_NOT_REACHED is really meant for things that aren't supposed
to ever happen (bugs in the dissector). Here it's being used just because
something unexpected came off the wire. A better thing to do here would be to
add an Expert Info saying the message is malformed and return.
- there's an awful lot of append_text()'s in here. Adding text means that the
fields are not filterable, which is not a good thing. It's better to use
add_item() (ideally) or at least add the fields using proto_tree_add_xxx().
- Has this passed fuzz testing? We'll need a sample capture before we can check
it in.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
