Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 5116] Added the VSIP protocol dissector

Date: Tue, 7 Sep 2010 23:20:04 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5116

--- Comment #8 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-09-08 08:19:59 CEST ---
<rant>Generate code is a maintenance nightmare</rant>:
#include <gmodule.h> should not be in the code.
Use of check_col() is deprecated.
if( tree ) Vsip_dissect(msg, proto_vsip, tvb, 0, pinfo, tree);
  Now Vsip_dissect may not manipulate the columns.

Property changes on: epan/dissectors/packet-vsip-entry.c
___________________________________________________________________
Added: svn:executable
   + *
It's not an executable, it's a source file.

const value_string EVsipEventType_value_string_table[]
  Why do all these need to be injected into the global namespace?



+      &VsipValueTypeString_Size_field_index,
+      {
+         "Size",
+         "VsipValueTypeString.Size",
+         FT_UINT16,
+         BASE_DEC,
+         NULL,
+         0x0,
+         "Size",
+         HFILL
+      }

When strcmp(name, blurp) == 0 -> blurp = NULL;

+guint32 _VsipValueTypeString_dissect
+   (
+      VsipValueTypeString *msg,
...
+   /* Disable unused variable warnings */
+   (void) msg;

The proper form is 

+guint32 _VsipValueTypeString_dissect
+   (
+      VsipValueTypeString *msg _U_,

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.