Wireshark-bugs: [Wireshark-bugs] [Bug 4807] PPP CHAP packets from USB links (in "HDLC-Like Frami
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4807

Chris Maynard <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4706|                            |review_for_checkin?
               Flag|                            |

--- Comment #2 from Chris Maynard <[email protected]> 2010-05-29 20:19:24 PDT ---
Created an attachment (id=4706)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4706)
Patch to handle compressed (NULL) address and control bytes.

The problem seems to be that the address and control bytes are missing,
presumably because they are compressed per section 3.2 of
http://tools.ietf.org/html/rfc1662.  The attached patch tries to account for
that.

The patch also fixes another bug.  If the hdlc framing character, 0x7e, is not
present, but the address and control fields are, then the offset might need to
be 3 bytes instead of only 2 bytes if the control field is escaped.  Sometimes
it is escaped and sometimes it isn't, so we need to handle both cases.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.