Wireshark-bugs: [Wireshark-bugs] [Bug 3045] Protocol Help extension for Wireshark
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3045

--- Comment #28 from Edgar Gladkich <[email protected]> 2010-05-26 02:42:51 PDT ---
(In reply to comment #26)
> Created an attachment (id=4684)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4684) [details]
> Updated protocol help
> 
> Edgar,
> 
> I've updated your patch with the following changes:
> 
> Rename "ph_" in some function names to "proto_help_". Move the protocol help
> code to its own module.
> 
> Make a bunch of functions static. Remove unused code.
> 
> Use browser_open_url() instead of our own functions.
> 
> Increase the logging levels. Don't clobber the normal log handler.
> 
> Update some Doxygen comments to match the format in the rest of the code base.
> 
> Removed GTK version checks. We've been 2.x only for a while.
> 
> Move ph_replace_string to string_replace() in epan/strutil.[ch].
> 
> Fix a bunch of memory leaks.
> 
> Add a NULL pointer check.
> 
> Reformat the overview menu label.
> 
> The goal is to generalize the code so that we can create configuration files
> for other web content, such as the Wireshark wiki, Wikipedia, or Wireshark
> University.
> 
> I tried to make it easy to insert variables into the URL, e.g. so that users
> can add a license key to the URL. See the comments in inacon.ini (which I'll
> attach next) for details.
> 
> If this works for you I'll check in before the 1.4 branch.


Hi Gerald,

i am glad that Protocol Help is taken up in Wireshrk. I have already given up
hope.

I still have a small remark. We should define in the configuration file only
the location to Protocol Help sources. If the URL variables contains, we depend
on a web server.

Here an example:

[database]
version=0.2.0
location=http://www.inacon.de/ph/data

The result after the call:

http://www.inacon.de/ph/data/DHCP/DHCP-Message-Format_OS_RFC-2131.htm

It also works on the local machine, thus without web server:

[database]
version=0.2.0
location=file:///F:/projects/ph/data

The result after the call:

file:///F:/projects/ph/data/DHCP/DHCP-Message-Format_OS_RFC-2131.htm

With your definition we are bound in the source code firmly to your format.
In addition, we depend online or offline on a web server.

thanks, Edgar

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.