Wireshark-bugs: [Wireshark-bugs] [Bug 3045] Protocol Help extension for Wireshark
Date: Mon, 24 May 2010 19:19:13 -0700 (PDT)

Gerald Combs <gerald@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
   Attachment #2587|review_for_checkin?         |
               Flag|                            |
   Attachment #2587|0                           |1
        is obsolete|                            |
   Attachment #4684|                            |review_for_checkin?
               Flag|                            |

--- Comment #26 from Gerald Combs <gerald@xxxxxxxxxxxxx> 2010-05-24 19:18:59 PDT ---
Created an attachment (id=4684)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4684)
Updated protocol help


I've updated your patch with the following changes:

Rename "ph_" in some function names to "proto_help_". Move the protocol help
code to its own module.

Make a bunch of functions static. Remove unused code.

Use browser_open_url() instead of our own functions.

Increase the logging levels. Don't clobber the normal log handler.

Update some Doxygen comments to match the format in the rest of the code base.

Removed GTK version checks. We've been 2.x only for a while.

Move ph_replace_string to string_replace() in epan/strutil.[ch].

Fix a bunch of memory leaks.

Add a NULL pointer check.

Reformat the overview menu label.

The goal is to generalize the code so that we can create configuration files
for other web content, such as the Wireshark wiki, Wikipedia, or Wireshark

I tried to make it easy to insert variables into the URL, e.g. so that users
can add a license key to the URL. See the comments in inacon.ini (which I'll
attach next) for details.

If this works for you I'll check in before the 1.4 branch.

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.