Wireshark-bugs: [Wireshark-bugs] [Bug 4757] New Protocol Submission for IEEE 802.1Qat (Multiple
Date: Thu, 13 May 2010 15:26:20 -0700 (PDT)

--- Comment #14 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-05-13 15:26:19 PDT ---
(In reply to comment #12)
> It exists on the link you posted with the following ethertype 22EA.
Yes indeed it does.  I searched for 22ea but "match case" had been set, so it
wasn't found.

One last scan revealed a couple more:
1) The Ethertype is still being displayed as "Unknown".  Sorry, that's my fault
for not telling you about packet-ethertype.c.  You should add ETHERTYPE_MSRP to
the etype_vals[] array with an appropriate description.

2) The only other comment I would make at this time is that the INFO column
won't have very informative information in it as all of these packets will
simply read, "Multiple Stream Reservation Protocol".  It might be better to add
some useful type summary information there, but I wouldn't know what that might
be.  I leave it up to you as to what else you might want to add there, if

... oh and these 2 trivial things:
1) There is a minor typo at line 581: atributes -> attributes.
2) Line 616 is the only line that still has tabs.

This pretty much concludes my review.  Once a new patch is submitted, one of
the core developers should have a look and commit the changes if he decides
it's ready.

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.