Wireshark-bugs: [Wireshark-bugs] [Bug 4757] New Protocol Submission for IEEE 802.1Qat (Multiple
Date: Thu, 13 May 2010 14:35:22 -0700 (PDT)

--- Comment #12 from Torrey Atcitty <[email protected]> 2010-05-13 14:35:19 PDT ---
(In reply to comment #10)
1) I moved the ethertype to etypes.h. The ethertype has already been assigned
actually. It exists on the link you posted with the following ethertype 22EA.

2) Done, added a link to the top of the source code.

3) Done, dunno how that happend but its fixed.

4) No worries. Several of us did development on this in separate environments
and VS made it decieving to me. I've fixed all tab issues though. 

5) Done.

6) Gotcha, Done.

7) Yes, actually it was intentional but it does look better to a user to
specify why it was skipped so I incorporated your comment. I've redone more
fuzz testing in addition to our own company in house testing and we have tested
the case before in addition to other weird data since we used this very
dissector to help debug our own malformed packets.

8 & 9) I actually had a long discussion about this with my principal engineer
Craig Gunther (also the editor of this protocol [MRP-MSRP]) and he thought that
it would be a nice addition for a future enhancement, but is not a show stopper
for now. That and I'm getting alot of pressure from the powers that be at my
company to get all "core" AVB protocols in the 1.4 release and I've got one
more dissector to get up to coding standards, tested and submit real quick
like. When I get more time, I could go back and update this with a new patch
since it is more for presentation reasons. Also, due to the random nature and
how the 4-packed and 3-packed events are encoded and decoded (3-packed events
are encoded tricky in the spec) my principal engineer believes it is sufficient
for now.

Thanks for all the comments.

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.