https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413
Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4558|review_for_checkin? |
Flag| |
Attachment #4558|0 |1
is obsolete| |
Attachment #4598| |review_for_checkin?
Flag| |
--- Comment #13 from Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> 2010-04-30 14:24:15 PDT ---
Created an attachment (id=4598)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4598)
Fix copy&paste error + add support for proto_tree_add_bits API
(In reply to comment #11)
> I like the bitview display selecting only the affected bits, but notice that it
> doesn't work when bits were added using proto_tree_add_bits_ret_val().
>
> I had a quick look at the code, and the mask used is taken from
> finfo->hfinfo->bitmask (in packet_hex_print()). proto_tree_add_bits_ret_val()
> only works when (hf_field->bitmask != 0).
>
> We could work out the bitmask in proto_tree_add_bits_ret_val(), but I'm not
> sure where it could be stored for packet_hex_print() to pick up and use
> later...
Thanks for pointing for proto_tree_add_bits API!
I haven't notice it before :)
attaching patch to add support for them and new version of patch for ip.flags.*
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
