https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4626
--- Comment #5 from Jouni Malinen <j@xxxxx> 2010-03-30 22:02:03 PDT ---
(In reply to comment #2)
> Could you please prefix all header fields with "hf_ieee80211_"
> e.g
> hf_tag_mobility_domain_mdid -> hf_ieee80211_tag_mobility_domain_mdid
OK.
> + {"Mobility Domain Identifier", "wlan_mgt.mobility_domain.mdid",
> + {"Mobility Domain Identifier", "ieee80211.wlan_mgt.mobility_domain.mdid",
Are you really recommending to add "ieee80211." prefix here? That's a user
visible change and this would be the only IE that actually uses the new prefix
while everything else would be using just the wlan_mgt..
> rsn_cap_mfpr -> hf_ieee80211_rsn_cap_mfpr
OK.
>
> Could
> + proto_tree_add_boolean(cap_tree, rsn_cap_mfpr, tag_tvb, tag_off, 2,
> + rsn_capab);
> :
> be replaced by proto_tree_add_item() ?
Sure.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
