https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4626
Anders Broman <anders.broman@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anders.broman@xxxxxxxxxxxx
--- Comment #2 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2010-03-30 07:22:50 PDT ---
This dissector is far from perfect but at least we can try to follow
the conventions when adding to it :-)
Could you please prefix all header fields with "hf_ieee80211_"
e.g
hf_tag_mobility_domain_mdid -> hf_ieee80211_tag_mobility_domain_mdid
:
+ {&hf_tag_mobility_domain_mdid,
+ {"Mobility Domain Identifier", "wlan_mgt.mobility_domain.mdid",
+ FT_UINT16, BASE_HEX, NULL, 0, NULL, HFILL }},
+ {"Mobility Domain Identifier", "ieee80211.wlan_mgt.mobility_domain.mdid",
rsn_cap_mfpr -> hf_ieee80211_rsn_cap_mfpr
Could
+ proto_tree_add_boolean(cap_tree, rsn_cap_mfpr, tag_tvb, tag_off, 2,
+ rsn_capab);
:
be replaced by proto_tree_add_item() ?
Do you have a small capture to verify the changes with?
regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
