Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 4210] Bug parsing IPv4 header flags field

Date: Sat, 7 Nov 2009 02:11:54 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4210


Filipe David Borba Manana <fdmanana@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guy@xxxxxxxxxxxx,
                   |                            |fdmanana@xxxxxxxxx,
                   |                            |jaap.keuter@xxxxxxxxx




--- Comment #6 from Filipe David Borba Manana <fdmanana@xxxxxxxxx>  2009-11-07 02:11:52 PDT ---
Ah, I had never heard about that stringification feature. Glad to know about
it, I had some situations in the past where it would have been very useful.

So, I attached another patch this time with stringification.
I added the 2 macros in the proto_register_ip(void) function. Not sure if it's
the best place to put them (instead of placing them at the top, together with
the others macros).

I am new to bugzilla, somehow I messed up :)

Could somebody then commit the patch?

cheers


(In reply to comment #5)
> Created an attachment (id=3925)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3925) [details]
> patch to fix bug with IPv4 header flags field analysis
> 
> This time using stringification.
> 

(In reply to comment #4)
> There's no clean way to do it, but you could do it with a macro that takes
> IP_OFFSET_WIDTH as an argument, stringifies it (you can only stringify
> arguments to a macro, not arbitrary stuff), and concatenates it with the stuff
> before it and after it in the string:
> 
>     http://gcc.gnu.org/onlinedocs/cpp/Stringification.html
> 
> (the fact that it's at gcc.gnu.org nonwithstanding, it's a part of standard C,
> not a GCCism).
> 
> (Also, you probably don't want to assign a bug to yourself unless you have
> commit access to the Wireshark repository; somebody with that access is needed
> to check the fix in, and, unless they've CCed themselves on the bug, they won't
> see the changes.)
> 


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.