https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4210
Filipe David Borba Manana <fdmanana@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Filipe David Borba Manana <fdmanana@xxxxxxxxx> 2009-11-06 02:35:42 PDT ---
(In reply to comment #1)
> I think you've got a point here.
>
> On the patch: I would rather see a symbol i.s.o. constant, like so:
> #define IP_OFFSET_WIDTH 13
>
> While we're at it, could we implement RFC 3514 as well? Needs to be a separate
> patch. Much too dangerous. ;)
>
Hello,
Yes, definitely, we should use a constant instead of hard coding the value 13
everywhere. Same goes for the flags field width (3).
I through about it actually, but since it was not done like that yet, I thought
I should stick to the current conventions.
I would be very glad to implement RFC 3514 as well. But on a different patch,
if you do agree.
I do have free time this weekend for it.
Glad to be helpful.
cheers
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
