ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 4189] Wireshark code indenting

Date: Mon, 2 Nov 2009 16:14:42 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4189


Markus <nepenthesdev@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|Enhancement                 |Major




--- Comment #3 from Markus <nepenthesdev@xxxxxxxxx>  2009-11-02 16:14:39 PDT ---
(In reply to comment #1)
> Note that any setting that involves the tab character in files going to tab
> stops other than 8n+1 will not work with some editors, and won't work with at
> least some other software (e.g., "more" on UN*X systems).
> 
> Note that any setting that involves the tab character in files going to tab
> stops other than 4n+1 might be difficult to make work with other editors.

I think you refer to
http://www.wireshark.org/lists/wireshark-dev/200907/msg00356.html

Essence is, some IDE software, including Microsoft Visual Studio Express fails
to allow setting indent tab width on a per-project basis, and therefore we
should use spaces.
Actually I disagree, as sticking with the minimum from all inputs results in
the minimum of all possible solutions.
To me it is not obvious why it is a problem if editor A renders tab as 4 spaces
where editor B renders tab as 8 spaces.

So, if you want to read code indented with 4 spaces, you'll have set tab-with
to 4, if you want to read code with tab-with 8, you'll have to set it to 8.
In both cases, everybody sees what he wants to - if you use tabs for indenting.
If you indent with spaces, there is no such choice, you'll see N-space-width,
independent of *any* personal preference.

I'm aware of at least one IDE where indent-with-spaces is a global setting too.


> As such, I would *VERY VERY VERY VERY VERY* strongly suggest that
> indent_with_tabs be set to 0, not 2.

Given your points, we could agree on 1 easily, indenting with tabs, alignment
with spaces.

But, I won't argue about it, as I don't care *which* setting is used, as long
as it is consistent.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.