Wireshark-bugs: [Wireshark-bugs] [Bug 4014] ICMP: Add ID and seq # to Info column
Date: Fri, 18 Sep 2009 21:04:14 -0700 (PDT)

Chris Maynard <[email protected]> changed:

           What    |Removed                     |Added
   Attachment #3657|review_for_checkin?         |
               Flag|                            |
Attachment #3657 is|0                           |1
           obsolete|                            |
Attachment #3658 is|0                           |1
           obsolete|                            |
   Attachment #3682|                            |review_for_checkin?
               Flag|                            |

--- Comment #2 from Chris Maynard <[email protected]>  2009-09-18 21:04:11 PDT ---
Created an attachment (id=3682)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3682)
New patch that displays seq # in both BE & LE plus adds TTL.

After I discovered that the Windows ping sends ICMP echo request packets with
the sequence number in little-endian byte order, but the Linux ping sends it in
proper big-endian format, a discussion about it took place on the mailing list
as to how to handle it (refer to
http://www.wireshark.org/lists/wireshark-dev/200909/msg00216.html).  However,
to keep things simple and avoid adding any new ICMP preferences and/or trying
to guess at the byte order, I thought why not just display the sequence number
in both formats, so that's what this patch does.

I also decided to add the ip_ttl to the packet_info structure so it could be
passed from the IP dissector to the ICMP dissector to be displayed in the Info
column, similar to what ping would show.

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.