Wireshark-bugs: [Wireshark-bugs] [Bug 3170] New plugin to dissect collectd network packets
Date: Sun, 13 Sep 2009 18:44:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3170


Jeff Morriss <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #18 from Jeff Morriss <[email protected]>  2009-09-13 18:44:01 PDT ---
I made some changes to the dissector and checked it in.  Particular changes
(that I remember :-)) include:
- don't call check_col() (it's no longer necessary)
- replace duplicated blurbs with NULL
- put all the collectd subtrees under one top-level tree
- add a few ett_ variables to keep the different trees separate
- replace tvb_ensure_length_remaining() with an offset of 0 with
tvb_reported_length()


I'm still not sure about using proto_tree_add_protocol_format() all the time...
 That's supposed to only be for the protocol's top-level entry.  But I don't
see the harm for now.

Thanks for your contribution!


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.