Wireshark-bugs: [Wireshark-bugs] [Bug 2981] Patch to add extension support to the X11 dissector
Date: Thu, 10 Sep 2009 11:30:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2981


Peter Harris <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2809|review_for_checkin?         |
               Flag|                            |
Attachment #2809 is|0                           |1
           obsolete|                            |
   Attachment #3641|                            |review_for_checkin?
               Flag|                            |




--- Comment #23 from Peter Harris <[email protected]>  2009-09-10 11:30:16 PDT ---
Created an attachment (id=3641)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3641)
Patch to add extension support v6

Okay, the opcode line was already special-cased, so it was relatively
straight-forward to special-case it a little bit more.
QueryExtension-reply-major_opcode isn't already special-cased, so it would be
more intrusive to fix. I don't believe it's that critical, since the
QueryExtension-request will be nearby in the protocol stream.

Otherwise, v6 does the trivial stuff (check_col, NULL instead of "" in hf_
entries, and the default-case omission comment). Plus it was rebased onto
r29841, and uses the latest Mesa and XCB/proto upstreams.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.