Wireshark-bugs: [Wireshark-bugs] [Bug 3970] New Dissector Plugin: CAPWAP Dissector
Date: Wed, 2 Sep 2009 00:21:22 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3970





--- Comment #5 from Tanmay Shete <[email protected]>  2009-09-02 00:21:18 PDT ---
(In reply to comment #4)
> Also:
> 
> 1.  if (proto_capwap_... == -1) { ...
> 
> not required in proto_register... since proto_register... is called only once
> during Wireshark startup.
> 
> 
> 2.  static const true_false_string capwap_wlan_bitmap = {
>     "WLAN 0-15",
>     "WLAN 0-15" 
> };/* Fudging Wireshark */
> 
> ???
> 
> 3. static const true_false_string capwap_set_truth = {
>     "Yes",
>     "No" 
> };
> 
> not needed in a normal dissector. Use tfs_yes_no.  
> (see epan/tfs.h and epan/tfs.c. #include tfs.h not req'd since it's included
> via packet.h).
> 
> 4. re:
> > preference changes aren't processed until restart. Provide a function for
> > that or tailor proto_reg_handoff_capwap() for the job.
> 
> See doc/readme.Developer
> 
> 5. Just about all of the functions other than proto_register...() &
> proto_reg_handoff...() should be static since they are presumably referenced
> only within packet-capwap.c
> 
> Ditto for the value_strings
> 
> 6. Are any of these #includes actually needed ?
> 
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> #include <ctype.h>
> #include <time.h>
> 
> 7.  Re:
> 
> Build Information:
> Version 1.0.99 (SVN Rev 26051)
> 
> This is a quite old version of Wireshark.
> 
> Please provides diffs against a current development version of Wireshark for
> any changes to existing files.
> 
> ==============
> 
> PS: Is there any particular reason this bug has been marked Private ?
> 

Can we make it public. I'm not able to change it now. While creating bug, by
mistake I marked it as private.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.