Wireshark-bugs: [Wireshark-bugs] [Bug 3802] New: Issue of ELEM_OPT_TLV when no more data availab
Date: Sun, 2 Aug 2009 06:49:40 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3802

           Summary: Issue of ELEM_OPT_TLV when no more data available
           Product: Wireshark
           Version: 1.2.1
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: Major
          Priority: Medium
         Component: Wireshark
        AssignedTo: [email protected]
        ReportedBy: [email protected]


Build Information:
Version 1.2.1 (SVN Rev 29141)

Copyright 1998-2009 Gerald Combs <[email protected]> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.2, with GLib 2.20.3, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8,
with c-ares 1.6.0, with Lua 5.1, with GnuTLS 2.8.1, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Jul 31 2009), with
AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.1
beta5
(packet.dll version 4.1.0.1452), based on libpcap version 1.0.0, GnuTLS 2.8.1,
Gcrypt 1.4.4, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
Hi,

I found an issue for ELEM_OPT_TLV,
if there isn't data left in the tvb,
the result will be "Malformed Packet".

I suggest adding two lines in function elem_tlv in packet-gsm_a_common.c:

  if(len<=0)
    return 0;

That means, if no data remaining in the tvb,
don't do anything.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.