https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2533
--- Comment #9 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-07-12 14:05:30 PDT ---
Hi Robert,
I've looked at the patch again and the telnet bit looks decent.
With regards to main part, did you do this one?
+ * TODO:
+ * Check for memleaks
+ *
That's the kind of stuff that makes us nervous. I found a g_malloc which
probably should be replaced by se_alloc.
+ goto done;
This makes Edsger Dijkstra turn over in his grave. I can't do that to my fellow
countryman.
The occasional C++ style comment should be stripped out.
+ if (check_col(pinfo->cinfo, COL_PROTOCOL))
These checks aren't needed anymore in new code.
The header fields look much better. You can optimize codesize by replacing
"FIELDDESCR" matching "FIELDNAME" with NULL, same goes for empty "FIELDDESCR".
+ tn3270_module = prefs_register_protocol(proto_tn3270,
proto_reg_handoff_tn3270);
Don't register the protocol for preferences when there are none.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
