https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3165
--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2008-12-31 09:51:12 PDT ---
Quick review:
Why all these complicated proto_tree_add_xxx calls? The header fields are setup
already, why not just call proto_tree_add_item()?
FT_IPv4 and FT_IPv6 have no use for the base field, so not BASE_DEC but
BASE_NONE.
Don't drop the volatile in "tvbuff_t *volatile next_tvb;" Certain compiler and
Valgrind will make a scene due to the TRY/CATCH implementation.
When header field 'name' and 'blurb' fields are the same you can set the
'blurb' field to NULL.
What's up with the field types 5 and 6? These are mentioned in the draft-09 but
not present in the code.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
