https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3158
Summary: follow.c: code with side effects in assert is bad style.
Product: Wireshark
Version: SVN
Platform: All
OS/Version: All
Status: NEW
Severity: Trivial
Priority: Low
Component: Wireshark
AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
ReportedBy: dgautheron@xxxxxxxx
didier gautheron <dgautheron@xxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2597| |review_for_checkin?
Flag| |
Created an attachment (id=2597)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2597)
move fwrite calls outside DISSECTOR_ASSERT()
Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi,
In follow.c there's stuff like:
DISSECTOR_ASSERT(... fwrite( data, 1, sc->dlen, data_out_file )
If DISSECTOR_ASSERT is defined as a noop then fwrite is not called.
The attached patch moves fwrite outside DISSECTOR_ASSERT()
Didier
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
