Wireshark-bugs: [Wireshark-bugs] [Bug 2687] Failure to dissect long SASL wrapped LDAP response
Date: Thu, 25 Sep 2008 05:10:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2687





--- Comment #9 from Yaniv Kaul <[email protected]>  2008-09-25 05:10:54 PDT ---
indeed, the fix is not in packet-ldap-template.c (only the comment was
fixed...):
/* check for a SASL header, i.e. assume it is SASL if 
         * 1, first four bytes (SASL length) is an integer 
         *    with a value that must be <LDAP_SASL_MAX_BUF and >2
         *    (>2 to fight false positives, 0x00000000 is a common
         *        "random" tcp payload)
         * (SASL ldap PDUs might be >64k in size, which is why 
         * LDAP_SASL_MAX_BUF is used - defined in packet-ldap.h)
         *
         * 2, we must have a conversation and the auth type must
         *    be LDAP_AUTH_SASL
         */
        sasl_len=tvb_get_ntohl(tvb, 0);

        if( sasl_len<2 ){
                goto this_was_not_sasl;
        }

        if( sasl_len>65535 ){
                goto this_was_not_sasl;
        }


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.