https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2707
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2008-07-22 05:14:56 PDT ---
Checked in rev 25787 with a couple changes:
1) There are a bunch of (new) value_strings and range_strings that were not
NULL terminated. This could cause a crash.
2) Don't call VALS() on range_strings--they need RVALS(). (That produced a
compile warning/error on Linux.)
If you're going to submit more patches against this I see a few other things
that could use improving in here:
- the comment at the top of the file still says SMPP 3.4
- there are many hard coded values in the code like:
+ case 0x0605: /* broadcast_frequency_interval */
I would prefer those to be #defines (which would then allow us to lose the
comments). And should those tags be added to the tree? If they were then the
#defines could also be used in a value string for pretty-printing.
Of course any updates to the SMPP Wiki page would also be welcome.
Thanks for your contribution!
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
