Wireshark-bugs: [Wireshark-bugs] [Bug 2689] [PATCH]: enhanced "what's past last mpls label?" heu
Date: Mon, 14 Jul 2008 23:49:06 -0700 (PDT)

--- Comment #6 from FF <[email protected]>  2008-07-14 23:49:05 PDT ---
(In reply to comment #5)
> I have committed the changes, since I didn't want to delay the expansion of
> this 
> functionality, but i would strongly suggest the modernization of the code:
> * Many items are retrieved from the TVB into a variable and then added with a
> formating function, like _add_uint_format(). The same can be achieved by
> properly filling out the header field definition and then adding the entry
> using _add_item(). I haven't seen any with which this couldn't be done.


> * The use of hidden fields, as mechanism to filter on, is deprecated for a
> reason. Without studying the sourcecode, or guesswork, it's impossible to know
> how to write a filter expression. If you think you need to resort to hidden
> fields, your display design is wrong and needs to be reconsidered.

ok, I tend to use hidden fields but I have to change my mind.

> * Checking protocol violations while dissecting is a good thing, but reporting
> it should be done via the expert info system. This has several advantages over
> simply adding text items.

I'll try to have a look at expert info framework

> Please take these suggestions to hart, we would welcome any updates.
> Committed revision 25730.

thanks a lot

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.