Wireshark-bugs: [Wireshark-bugs] [Bug 2290] GPRS LLC CRC24 badly calculated for non protected fr
Date: Wed, 9 Jul 2008 02:46:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2290


Vincent Helfre <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1991|                            |review_for_checkin?
               Flag|                            |




--- Comment #1 from Vincent Helfre <[email protected]>  2008-07-09 02:46:03 PDT ---
Created an attachment (id=1991)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=1991)
patch for the fcs problems

This patch contains the fix for FCS calculation of GPRS LLC frames:
- for UI frames in unprotected mode, the FCS is calculated on a maximum of N202
bytes
- for UI frames where the ciphered bit is set, FCS is still calculated to
determine whether the data is ciphered or not (it can have been unciphered) so
that the content can be further dissected. But it will indicate that FCS might
be wrong due to ciphering in the UI.
- the frame length that was used to dissect the data has been updated to a
correct value. Currently it was the CRC length being used, but it can happen
that the CRC does not cover all the data
- duplicated code for XID dissection has been put into a function. (I am
thinking of writing a dissector for L3 XID parameters)

Since the UI frame header has to be read before calculating the FCS, it has
changed the indentation in a big part of the code.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.