https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2584
Bruno Verstuyft <bruno.verstuyft@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1866|review_for_checkin? |
Flag| |
Attachment #1866 is|0 |1
obsolete| |
Attachment #1901| |review_for_checkin?
Flag| |
--- Comment #4 from Bruno Verstuyft <bruno.verstuyft@xxxxxxxxxxxx> 2008-06-23 01:47:22 PDT ---
Created an attachment (id=1901)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=1901)
Dissectors for MDD, REG-RSP-MP, REG-REQ-MP, SYNC
Concerning the call_dissector placed under the if(tree) (in packet-regreqmp and
packet-regrspmp):
This code is based on packet-regreq.c and packet-regrsp.c (already present in
docsis plugin). In this code, the call_dissector is also placed under the if
tree. I think the reason for this is that the docsis_tlv dissector is not
really a dissector for a seperate protocol, but some code to decode tlvs (which
are present in a lot of DOCSIS messages, and are part of these messages).
Indentation, C++ style comments and presence of moduleinfo.h and gmodule.h
issues are fixed.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
