http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2556
--- Comment #6 from Siva Jupudi <siva@xxxxxxxxxxxxxxxx> 2008-05-20 09:45:43 PDT ---
Any reason not to make this a build-in dissector?
The module stuff in packet-wsmp.c shouldn't be there, nor the occasional C++
comments.
>>> WSMP is completely a new protocol, and hence cannot be merged with build-in dissector, therefore I feel packet-wsmp.c should exist.
The documentation comments left in there could be purged as well.
>>> I will purge the c++ style comments, and submit the patch again
Why retrieve a string/letoh and then only add them to the tree? Use of
appropriate proto_tree_add_item() gives a better result.
>>> this was done as the acm/wsm fields are variable, and hence are required to retrieve the following variable field values
Let me know if you agree with, and I will submit with documentation comments
sorted out.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
