http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2084
------- Comment #5 from jet@xxxxxxxx 2007-12-10 09:48 GMT -------
Thank you for reviewing.
(In reply to comment #4)
> Did you fuzztest this dissector? I think not.
I should do. Not I've just run tools/fuzz-test.sh.
I've got "OK" 800 times.
>
> All your value strings need to be terminated by {0, NULL} tuple.
Fixed.
> if (check_col(pinfo->cinfo, COL_INFO))
> col_set_str(pinfo->cinfo, COL_INFO,
> val_to_str(h_cmd,
> dlm3_cmd,
> "packet-dlm3.c internal bug"));
> This does not signify a internal bug, it's a sign the packet doesn't conform
> the protocol spec.
This is really internal bugs. Before calling the `val_to_str', following
code is run:
h_cmd = tvb_get_guint8(tvb, 4 + 4 + 4 + 2) ;
if ((h_cmd != DLM3_MSG) && (h_cmd != DLM3_RCOM))
return 0;
If input data(h_cmd) holds a value not confirming to the protocol, the control
returns to the caller here.
> Please use NULL for empty blurbs in header fields. So 'NULL, HFILL }},' i.s.o.
> '"", HFILL }}'.
>
Fixed.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
