Wireshark · Ethereal-dev: Re: [Ethereal-dev] Optimization: remove the unconditional ip_checksum() in packet-ip?

[Ulf Lamping <ulf.lamping@xxxxxx>]

Kaul wrote:

> Attached patch.
> Comments are welcome + extensive testing, please.

Hi!

I had a look at your patch and checked in the part with the Preference 
setting, so you can switch of checksum calculation now.

The way you've changed the display of things has one great disadvantage 
(meaning to get all the values from the tvb before showing anything): if 
there's a problem in the IP header, you won't see any of the IP fields, 
even the ones that could be safely dissected.

The advantage of (very slightly) performance improvement might not be 
worth it (other's may disagree on this).

Carving out the changes in the checksum calculation and send another 
patch might be a good idea.

Regards, ULFL