Wireshark · Ethereal-dev: Re: [Ethereal-dev] Problem with graph_analysis and GTK 1

[Alejandro Vaquero <alejandrovaquero@xxxxxxxxx>]

Hi All,
   Find attached a patch for this.

Regards
Alejandro

Francisco Alcoba (TS/EEM) wrote:

> Hi,
>
> I am trying to update the flow graph patch to the current svn version, but I have 
> found a problem I don't know how to solve. When using the graph analysis function
> in Windows with GTK 1 -it happens with the "flow graph" but also with the current "voip calls"
> function- it gets in a loop, you see the graph window but the program hangs and you cannot close
> or do anything with it but kill the process.
>
> I've seen it continuously calls configure_event_comments and configure_event_time, which
> are callbacks defined for signals. But I don't really understand how these are called, or
> why it seems to loop. This happens with the current svn, but also when downloading
> the available buildbots, so I don't think is due to anything in my code.
>
> Can anybody help?
>
> Regards,
> Francisco 
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>  
Index: gtk/graph_analysis.c
===================================================================
--- gtk/graph_analysis.c	(revision 14750)
+++ gtk/graph_analysis.c	(working copy)
@@ -707,9 +707,11 @@
 #endif
 
 		/* resize the "time" draw area */
+#if GTK_MAJOR_VERSION >= 2
+		/* in GTK 1 it causes a loop of configure events */
         WIDGET_SET_SIZE(user_data->dlg.draw_area_time, label_width + 6, user_data->dlg.pixmap_height);
 		gtk_widget_show(user_data->dlg.draw_area_time);
-
+#endif
         left_x_border=3;
 		user_data->dlg.left_x_border = left_x_border;