Ethereal development <ethereal-dev@xxxxxxxxxxxx> schrieb am 24.03.05 11:28:45:
>
> On Thursday 24 March 2005 10:10, Ulf Lamping wrote:
> >
> > The way you describe it would make sense.
> >
> > But the current implementation uses the default enabling of the file
> > size as a mechanism to provide a meaningful default set. This mechanism
> > is used every time some setting had changed in the box.
> > The other possible way would leave both checkboxes unchecked, which
> > would mean having the default for multiple files always resulting in the
> > error message you've noticed above, which is even more undesirable IMHO.
>
> I just found out that the error message that I described is already in
> capture_dlg.c (although there seems to be no way to open it):
>
> ... if (!capture_opts->has_autostop_filesize && !capture_opts->has_file_duration) {
> simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK,
> PRIMARY_TEXT_START "Multiple files: No file limit given!\n\n" PRIMARY_TEXT_END
> "You must specify a file size or duration at which is switched to the next capture file\n"
> "if you want to use multiple files.");
>
Yes, and I've changed that text just this morning, by adding "or duration " although it currently will never be triggered.
> Why don't we just start with the default settings
> (has_autostop_filesize) and show this error message in case the user
> unchecks has_autostop_filesize without checking has_file_duration?
>
> I was looking at the struct capture_options_tag and am a little
> confused now:
You are still confused? Man, you should had a look at that code some months ago, at that time you would be *completely* confused ;-)
I've done *a lot* of effort (several weeks!) to cleanup these capture kind of things and I'm just a bit tired of that cleanup work now as the code was really a mess before and an annoying thing to cleanup.
> Are we misusing autostop_filesize to specify the size of
> each single file in case multiple files are used? If that's true, it
> should probably be documented.
"Misusing" is really a hard word, as it's almost doing what it's named implies :-)
That's the way it's currently implemented. I do agree it is a bit unclean.
Maybe I'm going to do some more work on the capturing engine in the near future, but time is rare and work is ...
Regards, ULFL
P.S: ... and the weather is becoming better and my motorcycle is still waiting!
______________________________________________________________
Verschicken Sie romantische, coole und witzige Bilder per SMS!
Jetzt bei WEB.DE FreeMail: http://f.web.de/?mc=021193
