Wireshark · Ethereal-dev: Re: [Ethereal-dev] DHCP option 43 dissection broken in SVN

[Guy Harris <gharris@xxxxxxxxx>]

Thomas Anders wrote:
> DHCP option 43 dissection (at least for CableLabs clients) doesn't work 
> correctly in current SVN. It probably got broken by some of the various 
> changes (all by Guy, so the blamelist is short ;-)) after Revision 12338 
> (which is the version that still works fine for me). packet-bootp.c now 
> ignores the TLV nature of the suboptions and uses a wrong offset (off by 
> 2): it displays type and length as values and leaves out the last two 
> bytes of the value.

It only does that for string options; the other options appear to be OK. 
 I've checked in a fix.

It was also, in several places, doing the check for whether the 
suboption data fits within the option wrong; I fixed that as well.

Your sample capture also has some other issues:

	in some packets, such as the first one, there are suboption 8 items 
that have 6 bytes, not 3, so it appears to encode the OUI as ASCII 
rather than binary;

	the DNS name stuff in CableLabs client configuration options isn't 
working - I'll look at that.