Wireshark · Ethereal-dev: Re: [Ethereal-dev] diameter vendor patch

[Guy Harris <gharris@xxxxxxxxx>]

Guy Harris wrote:
> Ben Turner wrote:
>
> > I attached a small patch for this.
>
> Checked in.

...and un-checked-in, just as Anders backed it out after having checked 
it in.

"code", not "id", is the numerical code, not the vendor ID.  Your patch 
caused a bug report:

	http://www.ethereal.com/lists/ethereal-users/200502/msg00318.html

So what are the cases you found where the vendors weren't being parsed 
properly?  The entries in the Diameter dictionary shipped with Ethereal 
look like

	<vendor vendor-id="Merit" code="61" name="Merit Networks"/>

Do the entries that had problems use "vendor-id" for the code and "code" 
for the vendor ID string?