We're now a non-profit! Support open source packet analysis by making a donation.

Ethereal-dev: Re: [Ethereal-dev] 0.10.5 patches

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <[email protected]>
Date: Sun, 25 Jul 2004 01:48:48 -0700
On Sat, Jul 24, 2004 at 11:30:30PM -0500, Albert Chin wrote:
> 1. [gtk/simple_dialog.c]
>    The function definition must match the prototype or the IBM C
>    compiler errors out.

The function definition is correct.  It's the prototypes for non-GCC 2.x
compilers that are incorrect; I've checked in a change to
"simple_dialog.h" to fix them.

Perhaps we should do as tcpdump does and define __attribute__(arg) as an
empty string on compilers that don't support it (or just on non-GCC 2.x
compilers), and use __attribute__(...) in all declarations, so that if a
declaration has to change there's only one declaration to change and
less chance that one will be fixed but not the other.

> 2. [acinclude.m4]
>    Don't assume u_int64_t exists. It doesn't on Solaris 2.5.1.

The right way to handle that is to do the checks after we've done the
GLib checks, and then use gint64 and guint64 as 64-bit types, as those
are the types used in Ethereal for 64-bit integers.  I've checked in a
change to do that.