Ethereal-dev: Re: [Ethereal-dev] Conversation/Endpoint list performance patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ian Schorr <[email protected]>
Date: Wed, 14 Jul 2004 10:57:27 -0400
Ulf Lamping wrote:

Did you keep in mind, that the address resolvings might change data being displayed? Is this done by the 3 seconds update?
Of course not.  =)

I'll re-write the patch. I haven't checked with a conversation with a *huge* number of hosts/conversations (thousands), but in my testing I see very little performance difference if I go ahead and have it update addresses for all entries in the list versus not as long as I keep the clist frozen while performing the update. Since the 3s update all rows are updated anyway and I don't think the draw_xxx_table_addresses routine is very costly as long as no clist redraws occur as a result, I think it will scale well if I leave this simple and put back in your original method (but freezing the clist until the updates are complete).
Ian