Ethereal-dev: Re: [Ethereal-dev] Enhancement request to http dissector

Note: This archive is from the project's previous web site, This list is no longer active.

From: "Guy Harris" <[email protected]>
Date: Tue, 13 Jul 2004 12:13:01 -0700 (PDT)
Yaniv Kaul said:
> To do so, I'd like to:
> (1) Move the zillion #define's in packet-ssl.c to packet-ssl.h (a good
> practice anyway?)

No, I'd just move the stuff *exported* by packet-ssl.c to other
dissectors, namely the declarations of the "ssl_looks_like" routines.

> (2) COPY the above mentioned functions from packet-ssl.c to
> packet-http.c and use it them (and include packet-ssl.h for the
> definitions).

Copy?  Why not just leave them in packet-ssl.c (as they know about SSL,
not HTTP) and just make them not static?