Wireshark · Ethereal-dev: [Ethereal-dev] [PATCH] 0.10.5 segfaults when applying/saving preferences with a bad font

[Pavel Kankovsky <kan@xxxxxxx>]

Ethereal 0.10.5 (built with GTK1) crashes when a font without a bold 
variant is selected and the preferences are applied/saved. The culprit is
font_fetch() returning TRUE but leaving new_font_name NULL (or undefined)
when user_font_test() fails.

--- ethereal-0.10.5/gtk/gui_prefs.c.orig	Fri Jul  2 02:06:46 2004
+++ ethereal-0.10.5/gtk/gui_prefs.c	Tue Jul 13 14:38:44 2004
@@ -371,7 +371,7 @@
     }
 
     g_free(font_name);
-	return TRUE;
+	return FALSE;
 }
 
 
-- 
Pavel Kankovsky, DCIT s.r.o., Kodanska 1441/46, 100 10 Praha 10, CZ
tel (+420) 234 066 114, fax (+420) 234 066 112, url http://www.dcit.cz/