Ethereal-dev: Re: [Ethereal-dev] [PATCH] [ISUP] Certain ISUP messages are reported as malforme

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Michael Tuexen <[email protected]>
Date: Fri, 2 Jul 2004 21:00:25 +0200
Guy,
see my comments in-line.
Best regards
Michael
On Jul 2, 2004, at 10:30 AM, Guy Harris wrote:

On Thu, Jul 01, 2004 at 10:45:03PM +0200, Martin van der Werff wrote:
ISUP messages without parameters like BLO, BLA and UBL are incorrectly
reported as malformed. The patch below fixes this problem.
I've checked that in - but, when constructing the parameter tvbuff, I
just use -1 for the lengths, so that its "reported length" is set
correctly even if the packet was cut short by a snapshot length (and
made some other changes).

It also renames the protocol to ISUP as this looks better in the
default layout.
I'll leave it up to the other ISUP dissector developers to indicate why
they tagged it with "(ITU)" (I don't see any place where it tags it as
"(ANSI)"; I assume the purpose of the "(ITU)" was to distinguish between
dialects of ISUP, assuming there *are* non-ITU dialects).

I would prefer to have the (ITU) stuff because we do the same for other
SS7 protocols (MTP3, SCCP, ...) where we have implemented also
ANSI and Chinese variants, which we have not done for ISUP. But it should
indicate that.
I'll also ask them if there's any reason not to:

@@ -5455,7 +5456,7 @@
  if (check_col(pinfo->cinfo, COL_INFO))
  {
   if (isup_show_cic_in_info)
- col_add_fstr(pinfo->cinfo, COL_INFO, "%s(CIC %u) ", val_to_str(message_type, isup_message_type_value_acro, "reserved"), cic); + col_add_fstr(pinfo->cinfo, COL_INFO, "%s (CIC %u) ", val_to_str(message_type, isup_message_type_value_acro, "reserved"), cic);
   else
col_add_fstr(pinfo->cinfo, COL_INFO, "%s ", val_to_str(message_type, isup_message_type_value_acro, "reserved"));
  }
...add in that extra white space.

I think that is OK.
_______________________________________________
Ethereal-dev mailing list
[email protected]
http://www.ethereal.com/mailman/listinfo/ethereal-dev