Ethereal-dev: RE: [Ethereal-dev] [PATCH] [ISUP] Certain ISUP messages are repor ted as malform

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Anders Broman (AL/EAB)" <[email protected]>
Date: Fri, 2 Jul 2004 13:05:32 +0200
Hi,
ISUP(ITU) was added because of 
http://www.ethereal.com/lists/ethereal-dev/200310/msg00292.html
As an ANSI ISUP message will (probaby) be wrongly decoded.
At the moment we do not decode ANSI ISUP or any national ISUP messages only ITU version.
Best regards
Anders 

-----Original Message-----
From: [email protected]
[mailto:[email protected]]On Behalf Of Guy Harris
Sent: den 2 juli 2004 10:31
To: Ethereal development
Subject: Re: [Ethereal-dev] [PATCH] [ISUP] Certain ISUP messages are
reported as malformed


On Thu, Jul 01, 2004 at 10:45:03PM +0200, Martin van der Werff wrote:
> ISUP messages without parameters like BLO, BLA and UBL are incorrectly
> reported as malformed. The patch below fixes this problem.

I've checked that in - but, when constructing the parameter tvbuff, I
just use -1 for the lengths, so that its "reported length" is set
correctly even if the packet was cut short by a snapshot length (and
made some other changes).

> It also renames the protocol to ISUP as this looks better in the
> default layout.

I'll leave it up to the other ISUP dissector developers to indicate why
they tagged it with "(ITU)" (I don't see any place where it tags it as
"(ANSI)"; I assume the purpose of the "(ITU)" was to distinguish between
dialects of ISUP, assuming there *are* non-ITU dialects).

I'll also ask them if there's any reason not to:

> @@ -5455,7 +5456,7 @@
>   if (check_col(pinfo->cinfo, COL_INFO))
>   {
>    if (isup_show_cic_in_info)
> -   col_add_fstr(pinfo->cinfo, COL_INFO, "%s(CIC %u) ", val_to_str(message_type, isup_message_type_value_acro, "reserved"), cic);
> +   col_add_fstr(pinfo->cinfo, COL_INFO, "%s (CIC %u) ", val_to_str(message_type, isup_message_type_value_acro, "reserved"), cic);
>    else
>     col_add_fstr(pinfo->cinfo, COL_INFO, "%s ", val_to_str(message_type, isup_message_type_value_acro, "reserved"));
>   }

...add in that extra white space.

_______________________________________________
Ethereal-dev mailing list
[email protected]
http://www.ethereal.com/mailman/listinfo/ethereal-dev