Wireshark · Ethereal-dev: RE: [Ethereal-dev] More updates to Oscar dissector

["Devin Heitmueller" <dheitmueller@xxxxxxxxxxx>]

Hello Jeimer,

I am definitely for splitting the file up.  I had similar concerns when I rewrote the bulk of the dissector and it ended up much larger than when I started.

Would recommend you break it up by SNAC family, which I believe is what you have proposed.  I would do this myself, but since I can't seem to get Ethereal to compile under OS X or Mandrake Linux (my two development platforms), I'm kind of stuck not being able to do any Ethereal development.

Devin Heitmueller
Senior Software Engineer
Netilla Networks Inc.


-----Original Message-----
From:	Jelmer Vernooij [mailto:jelmer@xxxxxxxxx]
Sent:	Sat 3/20/2004 2:46 PM
To:	ethereal-dev@xxxxxxxxxxxx
Cc:	
Subject:	[Ethereal-dev] More updates to Oscar dissector

Hi,

Here's another update of the Oscar dissector. It adds support for 
SNAC(x,1), SNAC(1,2-6) and SNAC(1,0x13).

I'm a bit worried about the packet-aim.c file becoming too large.
Would you object if I splitted it up into a main file (packet-aim.c) 
and several files for the services (packet-aim-generic.c, 
packet-aim-chatnav.c, packet-aim-adverts.c, etc) ?

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer@xxxxxxxxxxx> - http://jelmer.vernstok.nl/
Todo: 30