Wireshark · Ethereal-dev: Re: [Ethereal-dev] More updates to Oscar dissector

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

On Sat, Mar 20, 2004 at 12:07:46PM -0800, Guy Harris wrote about 'Re: [Ethereal-dev] More updates to Oscar dissector':
> On Sat, Mar 20, 2004 at 08:46:28PM +0100, Jelmer Vernooij wrote:
> > Here's another update of the Oscar dissector. It adds support for 
> > SNAC(x,1), SNAC(1,2-6) and SNAC(1,0x13).
> Checked in.
Thanks :-)

> Some warnings:

> 	../packet-aim.c: In function `dissect_aim_snac_error':
> 	../packet-aim.c:1066: warning: unused parameter `pinfo'
> 	../packet-aim.c: In function `dissect_aim_snac_icq':
> 	../packet-aim.c:1158: warning: unused parameter `tvb'
> 	../packet-aim.c:1159: warning: unused parameter `offset'
> 	../packet-aim.c:1159: warning: unused parameter `tree'

> Will those routines do more in the future, so that they use the
> arguments in question?
Yes. 

> > I'm a bit worried about the packet-aim.c file becoming too large.
> > Would you object if I splitted it up into a main file (packet-aim.c) 
> > and several files for the services (packet-aim-generic.c, 
> > packet-aim-chatnav.c, packet-aim-adverts.c, etc) ?
> I wouldn't.
Ok, then I'll split them.

Cheers,

Jelmer