ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Ethereal-dev: Re: [Ethereal-dev] Cleanup - conversation includes

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 3 Sep 2003 14:02:24 -0700

On Tuesday, July 8, 2003, at 6:53 AM, Greg Morris wrote:

I am not completely sure but I don't think you want to remove conversation.h from packet-ncp.c since conversations are used in the packet-ncp2222.inc file.

But nothing in packet-ncp.c, or that packet-ncp.c includes, uses conversations.

packet-ncp2222.inc is included by packet-ncp2222.c, so you can't remove the <epan/conversation.h> include from packet-ncp2222.c (I tried modifying ncp2222.py not to put that include in and, as I expected, packet-ncp2222.c didn't compile).