Wireshark · Ethereal-dev: [Ethereal-dev] incomplete bugfix in packet-ldap.c rev 1.161

[Bernd Leibing <bernd.leibing@xxxxxxxxxxxxxx>]

Hi,

I was busy hunting a coredump on solaris 9, which occurs when diseccting 
ldap requests.

Now I wanted to report a bug, but I realised that you guys already
produced a bugfix for this problem in packet-ldap.c rev 1.161.

It is very similar to my findings, but I think you missed one possible 
null pointer location.

The following patch is already against revision 1.161
Regards
	Bernd Leibing

--- ethereal/packet-ldap.c.orig	2003-07-31 14:13:07.000000000 +0200
+++ ethereal/packet-ldap.c	2003-07-31 16:11:31.000000000 +0200
@@ -900,7 +900,7 @@
     return;

   if (check_col(pinfo->cinfo, COL_INFO))
-	  col_append_fstr(pinfo->cinfo, COL_INFO, ", DN=%s", s);
+ 	  col_append_fstr(pinfo->cinfo, COL_INFO, ", DN=%s", s != NULL ? s : 
"(null)");
   g_free(s);

   start = a->offset;


Regards
	Bernd Leibing
--
Bernd 'Bing' Leibing     KIZ Infrastruktur, University of Ulm, Germany
Email: <bernd.leibing@xxxxxxxxxxxxxx>               Tel. 0731-50-22516
Homepage (PGP-Key): http://www.uni-ulm.de/~leibing            O26/5215