Wireshark · Ethereal-dev: Re: [Ethereal-dev] [PATCH] decouple dcerpc authentication from packet-dcerpc.c

[Tim Potter <tpot@xxxxxxxxx>]

On Tue, Jul 15, 2003 at 04:16:20PM -0700, Guy Harris wrote:

> >Again I'm putting this out there for anyone (probably Guy (-:) to 
> >comment
> >on.
> 
> The DCE_C_AUTHN_LEVEL_xxx #defines should probably all be moved to 
> "packet-dcerpc.h", to keep them together, even if not all of them are 
> used in calls to "register_dcerpc_auth_subdissector".  The 
> DCE_C_RPC_AUTHN_PROTOCOL_xxx values should probably be moved as well.

OK.  It seemed like too much work to have these various values distributed
throughout packet-ntlmssp.c and packet-spnego.c anyway.

I think there is a bit of an impedance mismatch between the function
signatures for the dcerpc_auth_subdissector_fns and the implementation
of the dissectors in packet-ntlmssp.c.  The dissect_auth_* functions
are just wrappers calling the ntlmssp dissectors.

I think making the functions of type new_dissector_t instead of
dcerpc_dissect_fnct_t would be a better match.


Tim.