Wireshark · Ethereal-dev: RE: [Ethereal-dev] packet-wsp.c - parameter decoding

[Biot Olivier <Olivier.Biot@xxxxxxxxxxx>]

Hi Guy,

I included your proposed fix in the attached patch. Summary:

* Fix the Extended Method PDU mapping (move code some lines down)
* Decode more WSP Parameter entries (now WAP Provisioning Push OK)
* First check whether the PDU content for Post, Reply and Push PDUs
  can be dissected (dissector_try_X function calls), if not then
  display the PDU data as "Data" in the WSP protocol tree.
* Replaced "Unsupported header" by "Undecoded header" for clarity

Please review and check in.

Regards,

Olivier


> -----Original Message-----
> From: Guy Harris [mailto:guy@xxxxxxxxxx]
> 
> It should't put the "Push Data" item into the protocol tree 
> unless both
> the "dissector_try_port()" call and the 
> "dissector_try_heuristic()" call
> return FALSE (if either of them succeed, that data is already in the
> protocol tree, dissected as whatever protocol those calls chose).
>

Attachment: packet-wsp.c.diff
Description: Binary data