Wireshark · Ethereal-dev: Re: [Ethereal-dev] New dissector: HP rboot

[Jochen Friedrich <jochen+ethereal@xxxxxxxx>]

Hi Guy,

> The "Machine Type" field in boot requests appears to be a text string in
> your trace.  Is it always a text string?

I checked the rbootd sources and the debugging code seems to indicate that
this might be true...

                (void) fprintf(DbgFp, "\n\t\tMachine Type: ");
                for (i = 0; i < RMP_MACHLEN; i++)
                        (void) fputc(rmp->r_brq.rmp_machtype[i], DbgFp);

Additionally, HP seems to reference the protocol "Remote Maintenance
Protocol", so i fixed that as well.

Thanks,
--jochen

Index: packet-rmp.c
===================================================================
RCS file: /cvsroot/ethereal/packet-rmp.c,v
retrieving revision 1.1
diff -u -r1.1 packet-rmp.c
--- packet-rmp.c	2 Mar 2003 21:52:19 -0000	1.1
+++ packet-rmp.c	3 Mar 2003 07:12:45 -0000
@@ -233,7 +233,7 @@
 		{ "Version", "rmp.version", FT_UINT16, BASE_DEC,
 			NULL, 0x0, "", HFILL }},
 		{ &hf_rmp_machtype,
-		{ "Machine Type", "rmp.machtype", FT_BYTES, BASE_HEX,
+		{ "Machine Type", "rmp.machtype", FT_STRING, BASE_DEC,
 			NULL, 0x0, "", HFILL }},
 		{ &hf_rmp_filename,
 		{ "Filename", "rmp.filename", FT_UINT_STRING, BASE_DEC,
@@ -250,7 +250,7 @@
 	};
 
 	proto_rmp = proto_register_protocol(
-	    "HP Remote Management Protocol", "RMP", "rmp");
+	    "HP Remote Maintenance Protocol", "RMP", "rmp");
 	proto_register_field_array(proto_rmp, hf, array_length(hf));
 	proto_register_subtree_array(ett, array_length(ett));